fix(toolbar): removed margin modifiers, updated gap declaration #6813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview: https://patternfly-pr-6813.surge.sh A11y report: https://patternfly-pr-6813-a11y.surge.sh |
mattnolting
commented
Jun 21, 2024
| @@ -37,7 +37,6 @@ $pf-v6--include-toolbar-breakpoints: true !default; | |||
| --#{$toolbar}__content--RowGap: var(--pf-t--global--spacer--sm); | |||
| --#{$toolbar}__content--PaddingBlock: var(--pf-t--global--spacer--md); | |||
| --#{$toolbar}__content--PaddingInline: var(--#{$toolbar}--PaddingInline); | |||
| --#{$toolbar}__content--PaddingBlockStart: 0; | |||
There was a problem hiding this comment.
This works well for page padding. It will need to be isolated the page or updated otherwise.
mattnolting
force-pushed
the
fix-toolbar-6683
branch
from
796ac7f
to
c65d71e
Compare
mattnolting
force-pushed
the
fix-toolbar-6683
branch
from
c65d71e
to
dd8caca
Compare
mattnolting
changed the title
mcoker
approved these changes
Jun 21, 2024
|
🎉 This PR is included in version 6.0.0-alpha.168 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #6701