Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[component-groups | LogSnippet] - Rename leftBorderVariant #668

Open
fhlavac opened this issue Jun 21, 2024 · 0 comments
Open

[component-groups | LogSnippet] - Rename leftBorderVariant #668

fhlavac opened this issue Jun 21, 2024 · 0 comments

Comments

@fhlavac
Copy link

fhlavac commented Jun 21, 2024

Follow up to breaking change PR

We've renamed LogSnippet prop because of design changes and switching from border variant to alert variant

rename
leftBorderVariant to variant

The LogSnippetBorderVariant has been removed and replaced with PF AlertVariant. Perhaps the current values could be mapped to the new ones since the types almost match

Example:

<LogSnippet message='Failure - check logs for details' logSnippet={code} leftBorderVariant={LogSnippetBorderVariant.success} />

becomes

<LogSnippet message='Failure - check logs for details' logSnippet={code} variant={AlertVariant.success} />

or

<LogSnippet message='Failure - check logs for details' logSnippet={code} variant="sucess" />

Required actions:

  • Build codemod
  • Build test
  • Update readme with description & example
@fhlavac fhlavac changed the title [component-groups | LogSnippet] - Rename props [component-groups | LogSnippet] - Rename leftBorderVariant Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Needs triage
Development

No branches or pull requests

2 participants