Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Support for Top-to-Bottom Pipelines View #136

Closed
jenny-s51 opened this issue Feb 5, 2024 · 1 comment · Fixed by #148
Closed

Feature: Support for Top-to-Bottom Pipelines View #136

jenny-s51 opened this issue Feb 5, 2024 · 1 comment · Fixed by #148

Comments

@jenny-s51
Copy link
Collaborator

jenny-s51 commented Feb 5, 2024

Describe the problem
A clear and concise description of the problem. Which components are affected?

The pipelines logic for drawing nodes/and edges doesn't support vertical layouts.

Following discussions with @andrewballantyne and @jeff-phillips-18 related to new RHOAI designs for v2 pipelines:

Using the PF topology provided TaskNode and TaskEdge components will not work top to bottom [...] There should be an option added to PF topology pipelines for top to bottom. Would need to create new node and edge components to support this
@jeff-phillips-18

See draw-utils.ts for edge logic and
PipelineDagreLayout.tsx for layout attributes.

How do you reproduce the problem?

Current Pipelines layout only supports drawing from left to right. https://www.patternfly.org/topology/pipelines

Expected behavior

Pipelines support for Top to Bottom layout.

What is your product and what release date are you targeting?
RHOAI

@jenny-s51 jenny-s51 changed the title Feature: Support Top-to-Bottom Pipelines View Feature: Support for Top-to-Bottom Pipelines View Feb 5, 2024
@jeff-phillips-18 jeff-phillips-18 self-assigned this Feb 12, 2024
@jessiehuff jessiehuff added this to the 2024 Q1 - Sprint 4 milestone Feb 13, 2024
Copy link

🎉 This issue has been resolved in version 5.3.0-prerelease.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants