Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

review collapsible pattern #35

Closed
chaoflow opened this issue Mar 7, 2012 · 2 comments
Closed

review collapsible pattern #35

chaoflow opened this issue Mar 7, 2012 · 2 comments
Assignees

Comments

@chaoflow
Copy link
Contributor

chaoflow commented Mar 7, 2012

I reworked collapsible:

  • pattern as jquery plugin
$('.some').collapsible()
$('.come').open() 
$('.come').close(0) 
$('.come').toggle()  
  • pattern triggered via markup
  • free the pattern code from generic stuff now handled in patterns
  • use demo/collapsible.html as base for jasmine-jquery tests

Please review/comment the approach.

@ghost ghost assigned wichert Mar 7, 2012
@cornae
Copy link
Member

cornae commented Mar 7, 2012

Demo page no longer works on my side.

Safari 5.1.3 (7534.53.10)

patterns.js:5SyntaxError: Expected token ']'
main.js:49TypeError: 'null' is not an object (evaluating 'mapal.newstyle.scan')
require.js:1538Error: Load timeout for modules: lib/domReady!
http://requirejs.org/docs/errors.html#timeout

Op 7 mrt. 2012, om 15:37 heeft Florian Friesdorf het volgende geschreven:

I reworked collapsible:

  • pattern as jquery plugin
$('.some').collapsible()
$('.come').open() 
$('.come').close(0) 
$('.come').toggle()  
  • pattern triggered via markup
  • free the pattern code from generic stuff now handled in patterns
  • use demo/collapsible.html as base for jasmine-jquery tests

Please review/comment the approach.


Reply to this email directly or view it on GitHub:
https://github.com/cornae/Patterns/issues/35

@chaoflow
Copy link
Contributor Author

chaoflow commented Mar 7, 2012

sorry - partial commit - should be fixed

@wichert wichert closed this as completed Oct 18, 2012
garbas pushed a commit to garbas/Patterns that referenced this issue Sep 7, 2015
fix unicodedecodeerror when inviting members to workspaces that contains non-ascii characters in the title, ref Patternslib#35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants