Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B2 Feedback #1

Open
yuliaUU opened this issue Nov 29, 2021 · 3 comments
Open

B2 Feedback #1

yuliaUU opened this issue Nov 29, 2021 · 3 comments

Comments

@yuliaUU
Copy link

yuliaUU commented Nov 29, 2021

Great work

  • README: tidyverse a package should not be installed outside the function, it should be included in teh package suppressMessages(library(tidyverse))
  • extra () around group_counts(as_tibble(iris), Species), they are redundant
  • failed check()
    image
  • passed test()
  • extra stuff ina repo ( Assignment 1)
  • library(tidyverse) library(datateachr) should not be loaded insid eyour function
@pattiey
Copy link
Owner

pattiey commented Nov 29, 2021

library(tidyverse) library(datateachr) were remnants from A1 and were unneeded in the groupCounts.R file. Deleting these lines also removes the check failure :(

@yuliaUU
Copy link
Author

yuliaUU commented Nov 29, 2021

it seems that you did not import them properly inside your package

@yuliaUU
Copy link
Author

yuliaUU commented Nov 29, 2021

or you need to refer to them as datateachr::

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants