Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal to upgrade to 5.1.0 #222

Closed
superhit0 opened this issue Jul 3, 2018 · 12 comments
Closed

Proposal to upgrade to 5.1.0 #222

superhit0 opened this issue Jul 3, 2018 · 12 comments
Labels

Comments

@superhit0
Copy link
Collaborator

superhit0 commented Jul 3, 2018

@patw0929 Can we upgrade this repo to 5.1.0 by making utilScript optional & removing libphonenumber.js from the dist folder & making webpack load libphonenumber from bundle & chunking those two files.

This is the sample code change I have done to dynamically download the libphonenumber in case utilScript is not given.

https://github.com/patw0929/react-intl-tel-input/compare/master...superhit0:util-option?expand=1

We can also start our Changelog with this version.

What are your thoughts?

@patw0929
Copy link
Owner

patw0929 commented Jul 3, 2018

Good idea!
Sorry I am still busy at work. I'll try your PR when I get home tonight.

@patw0929
Copy link
Owner

patw0929 commented Jul 3, 2018

It will worth to try! Please make it as a PR.
And could you make a todo list at this thread?

@superhit0
Copy link
Collaborator Author

Sure, I am busy with work too. Lets try this weekend.

@superhit0
Copy link
Collaborator Author

superhit0 commented Jul 8, 2018

@patw0929
Came up with toDo list for 5.1.0:

  • Fix cursor issue
  • Bundle libphonenumber.js with webpack
  • Update componentWillReceiveProps with react Upgrade
  • Removed utilsScript
  • Remove libphonenumber
  • Add ChangeLog.
  • Update Readme if libphonenumber removed from dist

Please suggest additions/deletions of any ideas.

@patw0929
Copy link
Owner

patw0929 commented Jul 8, 2018

Awesome!

Maybe we should consider the change of componentWillReceiveProps will deprecated in future 16.x release, but if it has lots of change to do, next release is ok too.

ref: https://reactjs.org/docs/react-component.html#static-getderivedstatefromprops

@superhit0
Copy link
Collaborator Author

Sounds Good, I am adding it to the todo list. Since this is a major change, I would prefer it to go in a 0.1 version upgrade rather than any 0.0.1 upgrade.

@superhit0
Copy link
Collaborator Author

I think we should also increase our coverage to 100%, but that can go later as it will not affect the functionality or usage of the components

@superhit0
Copy link
Collaborator Author

Can we close the above list for the upgrade or do we want to add few more things?

According to me, the above changes should not take more than 1~1.5 weeks including merging tasks.

@patw0929 Shall we start on this?

@patw0929
Copy link
Owner

patw0929 commented Jul 9, 2018

Sure! I think this list is good enough.
We can start! 🙌 Thanks!

@superhit0
Copy link
Collaborator Author

@patw0929 Can you do this Remove libphonenumber from dist [Due to Bundling]?

I can work on Update componentWillReceiveProps with react Upgrade.

@patw0929
Copy link
Owner

OK, no problem. I will handle it later.

@patw0929
Copy link
Owner

Because of the breaking change, it published as v6.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants