-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal to upgrade to 5.1.0 #222
Comments
Good idea! |
It will worth to try! Please make it as a PR. |
Sure, I am busy with work too. Lets try this weekend. |
@patw0929
Please suggest additions/deletions of any ideas. |
Awesome! Maybe we should consider the change of ref: https://reactjs.org/docs/react-component.html#static-getderivedstatefromprops |
Sounds Good, I am adding it to the todo list. Since this is a major change, I would prefer it to go in a |
I think we should also increase our coverage to |
Can we close the above list for the upgrade or do we want to add few more things? According to me, the above changes should not take more than 1~1.5 weeks including merging tasks. @patw0929 Shall we start on this? |
Sure! I think this list is good enough. |
@patw0929 Can you do this I can work on |
OK, no problem. I will handle it later. |
Because of the breaking change, it published as v6.0.0. |
@patw0929 Can we upgrade this repo to
5.1.0
by making utilScript optional & removinglibphonenumber.js
from the dist folder & making webpack loadlibphonenumber
from bundle & chunking those two files.This is the sample code change I have done to dynamically download the
libphonenumber
in case utilScript is not given.https://github.com/patw0929/react-intl-tel-input/compare/master...superhit0:util-option?expand=1
We can also start our Changelog with this version.
What are your thoughts?
The text was updated successfully, but these errors were encountered: