Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Stage Variable support #5

Open
camhart opened this issue Jan 12, 2017 · 2 comments
Open

Add Stage Variable support #5

camhart opened this issue Jan 12, 2017 · 2 comments

Comments

@camhart
Copy link

camhart commented Jan 12, 2017

You had stage variable support basically completed... So I finished it.

#4
@paulSambolin
Copy link
Owner

I actually grabbed most of this from an implementation for stage variables. We needed to enable logging in a CI/CD so I made a separate plugin. If you confirm it works I would be glad to accept and re-publish

@camhart
Copy link
Author

camhart commented Jan 12, 2017

I just realized--right now there is no way to use the stage variables but NOT enable api gateway logging. I want both--but I think it should probably be changed to have api-gateway-logging toggle-able through a serverless.yml setting.

If you like that idea--I'm open to adding it in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@camhart @paulSambolin