Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow artifact stats to be configurable #14

Open
paularmstrong opened this issue Mar 20, 2018 · 7 comments
Open

Allow artifact stats to be configurable #14

paularmstrong opened this issue Mar 20, 2018 · 7 comments
Milestone

Comments

@paularmstrong
Copy link
Owner

paularmstrong commented Mar 20, 2018

Use case

Not all projects are concerned with gzip sizes of artifacts. For example: native iOS and Android applications.

This is a bit 2.0.0 thinking, but I would still like others to weigh in on how this type of thing might be achieved and/or if it's necessary.

Solution

Artifact stats could be configurable via the server application and passed to the frontend application. The application would then give toggles for each type defined.

It could still default to gzip and stat declaring themselves as bytes and work the same as the application does now:

type ArtifactStats = {
  [key: string]: 'bytes' | 'duration'
};

createServer({
  artifactStats: ({ gzip: 'bytes', stat: 'bytes' }: ArtifactStats)
});
@eps1lon
Copy link
Contributor

eps1lon commented Jun 3, 2019

Not all projects are concerned with gzip sizes of artifacts.

Not sure if this is the right issue but I'd be interested in tracking arbitrary values. For example tracking benchmark results or lighthouse scores. So far it looks like I can only configure files as artifacts and it automatically assumes I want to track their size.

@paularmstrong
Copy link
Owner Author

@eps1lon This is something I'm definitely interested in for Build Tracker!

That being said, it's a pretty big undertaking to think through and not something for the 1.x release. Many moving pieces that I can go into detail with if you'd like to contribute 😄

@eps1lon
Copy link
Contributor

eps1lon commented Jun 4, 2019

I have to figure out the whole self-hosting story first. That's a pretty big adoption hurdle compared to solutions that provide the server. But hearing that this is in the scope makes me more motivated to figure it out.

@paularmstrong
Copy link
Owner Author

I have to figure out the whole self-hosting story first.
Related to #66

@OliverJAsh
Copy link
Collaborator

For the graphs, I noticed that Brotli is the default size type. We don't currently use Brotli so we would like the graphs to default to using gzip instead. Is this an easy change to make?

I noticed we have a sizeKey in Redux state. that defaults to ''. Changing that to 'gzip' didn't seem to do anything 🤔

@paularmstrong
Copy link
Owner Author

The default currently goes to whatever is alphabetically first and can be changed with toggles in the drawer. I think a config option to set default would work.

@OliverJAsh OliverJAsh mentioned this issue Feb 18, 2020
3 tasks
@paularmstrong paularmstrong added this to the v2.0.0 milestone Mar 15, 2020
@OliverJAsh
Copy link
Collaborator

Related to this: I would love to see support for passing a custom quality level to Brotli. (We use the maximum quality level—11.)

Do you think we could support something like that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants