Fixed a errors that occurred during running unit tests for .NET Framework 4.5 version #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What errors are you seeing, exactly? I tried switching to your PR branch but I had no errors when running the unit tests. |
|
Hello, Paul! Errors in unit tests for .NET Framework 4.5 version was caused by the following block of code from a #if ENABLE_DEBUGGING
if (name != null)
local.SetLocalSymInfo(name);
#endifI removed this block of code. |
|
This is going to result in poorer debugging support though, right? What error message are you getting? |
|
If run a Unit Tests project, that targeted on .NET Framework 4.6.1, by using the following command: Then get the following errors (see a full version in the |
|
Any ideas how to fix these errors? |
|
If you're getting |
|
This is a normal test practice for a multi-target project. |
You can get this error in .NET Framework 4.5 version of Jurassic, even if you run the simplest console application: using Jurassic;
namespace ConsoleApp
{
class Program
{
static void Main(string[] args)
{
var engine = new ScriptEngine();
engine.Execute("var engines = ['Chakra', 'Jurassic', 'SpiderMonkey', 'V8'];");
}
}
}This error is caused by the following block of code from a if (name != null)
local.SetLocalSymInfo(name);This block of code is never called in .NET Standard 2.0 version of Jurassic. For a long time this block was commented out. |
|
You're right, I apologize. I've checked in a fix that preserves the debugging functionality (67740c1). |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.