New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BET fitting #3

Open

sblanky opened this issue Feb 10, 2022 · 1 comment

sblanky commented Feb 10, 2022

Currently it's a bit fiddly to select the appropriate relative pressure region. A couple things I think could improve this;

Being able to drag the limits
Range of x axis decreasing with selected range, i.e. if selected range is 0.05-0.3, x-axis is 0.03-0.32. Having the full range is not helpful.
Matching Rouquerol plot to above.

This however may just be preferences I have coming from the MicroActive software.

Owner

pauliacomi commented Mar 8, 2022

Thanks for the suggestions.
Unfortunately limit dragging will be nearly impossible to implement because of how the graph is structured.

I've tried to improve the limit selection as it is right now. Now you can go into log mode and fine-tune the limits in the low pressure region:

I'll have to think how to improve it further by maybe matching limits across all graphs...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment