Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Modelling in pyGAPS #29

Closed
sblanky opened this issue Jan 18, 2022 · 3 comments
Closed

Documentation: Modelling in pyGAPS #29

sblanky opened this issue Jan 18, 2022 · 3 comments

Comments

@sblanky
Copy link
Contributor

sblanky commented Jan 18, 2022

In the list of models, all are given in lower case. From my implementation, they don't actually work like that Not all models provided correspond to internal models

It does work if you use the appropriate case though i.e. 'Langmuir', 'DSLangmuir', 'GAB'.

Documentation could be updated to reflect this.

Thanks,
Scott

@pauliacomi
Copy link
Owner

Thanks for pointing it out.
Maybe it would be best if the case shouldn't matter, so you could pass any of Langmuir, LANGMUIR or LaNgMuIr.
How does that sound?
-pi

@sblanky
Copy link
Contributor Author

sblanky commented Jan 18, 2022

That does sound like the best option!

@pauliacomi
Copy link
Owner

Should be fixed by cc869bf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants