Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Actually use progressive enhancement with a link rather than button #117

Merged
merged 3 commits into from Jan 28, 2022
Merged

Actually use progressive enhancement with a link rather than button #117

merged 3 commits into from Jan 28, 2022

Conversation

aarongustafson
Copy link
Contributor

Closes #113

@aarongustafson
Copy link
Contributor Author

Tested: https://lite-youtube-embed-f0314late-paulirish.vercel.app/variants/pe.html

@aarongustafson aarongustafson mentioned this pull request Jan 26, 2022
Closed
paulirish
paulirish approved these changes Jan 28, 2022
View reviewed changes
Copy link
Owner

@paulirish paulirish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this is great. Thanks for the issue and following up with PR.
Sorry for the delay responding, but I was onboard from the start.

Appreciate it, aaron!

@paulirish paulirish changed the title Updates for true Progressive enhancement Actually use progressive enhancement with a link rather than button Jan 28, 2022
@paulirish paulirish merged commit 5dfa1ab into paulirish:master Jan 28, 2022
@aarongustafson
Copy link
Contributor Author

Thanks @paulirish! I totally forgot to update the Readme. Do you want me to submit a PR with that update too?

@aarongustafson aarongustafson deleted the progressive-enhancements branch January 28, 2022 02:39
@paulirish
Copy link
Owner

that'd be super great, yeah.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulirish paulirish paulirish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The "Progressive Enhancement" approach does nothing
2 participants
@aarongustafson @paulirish