Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to circe-config #120

Closed
zakpatterson opened this issue Jan 4, 2019 · 5 comments
Closed

Switch to circe-config #120

zakpatterson opened this issue Jan 4, 2019 · 5 comments

Comments

@zakpatterson
Copy link
Collaborator

For consistency, we should use circe-config instead of pureconfig.

@pauljamescleary
Copy link
Owner

Is there an advantage to circe-config over pure-config? I am more-or-less curious as I haven't dived into a detailed comparison.

@zakpatterson
Copy link
Collaborator Author

zakpatterson commented Jan 9, 2019

I don't think there could be any measurable advantage, it just seems like a more natural choice for this project since we're already using circe. Also c-c doesn't do kebab-case like p-c does which seemed weird to me. Here's a line where I used it in another project, although we wouldn't need to use all the ApplicativeAsk complexity here:

https://github.com/clovellytech/http4s-modules/blob/master/db/src/main/scala/h4sm/db/config/package.scala#L21

@zakpatterson
Copy link
Collaborator Author

I went ahead and did it, let me know what you think.

@franklinchou
Copy link

This was closed by #123, no?

@zakpatterson
Copy link
Collaborator Author

Fixed with #123, thanks @franklinchou !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants