Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic recompute of Links (ArchWindow, ArchEquipment) after creation #6

Closed
balrobs opened this issue Jan 22, 2021 · 2 comments
Closed
Assignees
Labels
enhancement New feature or request

Comments

@balrobs
Copy link

balrobs commented Jan 22, 2021

If users forget to start a recompute after creating Archwindow and ArchEquipment Links the attach command sometimes gives un unexpected result!
See Forum discussion:
https://forum.freecadweb.org/viewtopic.php?f=23&t=50802&start=110#p469507

@paullee0
Copy link
Owner

Details of what happens -

  1. After creating the Link, the system has not recomputed it (there is a mark indicating recompute is pending)
  2. The appLinkExecute() which includes setPropertiesLinkCommon() to add Hosts property is thus not run
  3. When the AttachToEdge tool is used, it thus set the Hosts[0] of the Linked Object, instead of the Link's new Hosts[0], to the new target Object to Attach, thus wrong

Solution -

  1. Either the FC should not postpone the recompute() of a Link, or
  2. AttachToEdge tool check if it is a Link Object, and if the Link.State list includes "Touched", make it recompute()

@paullee0
Copy link
Owner

paullee0 commented Feb 2, 2021

Commit to fix the problem
2ca3698

Hope more peoples can test if it works :D

@paullee0 paullee0 self-assigned this Feb 7, 2021
@paullee0 paullee0 added the enhancement New feature or request label Feb 7, 2021
@paullee0 paullee0 closed this as completed Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants