Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Match libdatachannel's reliability.hpp #54

Closed
golgirihm opened this issue May 29, 2024 · 1 comment · Fixed by #51
Closed

Match libdatachannel's reliability.hpp #54

golgirihm opened this issue May 29, 2024 · 1 comment · Fixed by #51

Comments

@golgirihm
Copy link
Contributor

golgirihm commented May 29, 2024 •
edited
Loading

Hello!

First off, thank you for the wonderful libraries. They are incredibly useful!

I have a project that uses libdatachannel in conjuction with datachannel-wasm. Recently, I pulled to a newer version of libdatachannel, and found that I had a build error due to the refactor of the data channel reliability API (#1031). I was able to fix this error in one part of my project (the native app), but it breaks the other part of the project (the web app).

Is there a plan to update datachannel-wasm to match the reliability in the latest libdatachannel?
@paullouisageneau
Copy link
Owner

This is done in #51 which is not merged, I was waiting for the new version of libdatachannel to be released.

I'll merge it now!

@paullouisageneau paullouisageneau linked a pull request May 29, 2024 that will close this issue
Refactor reliability API #51
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor reliability API paullouisageneau/datachannel-wasm
2 participants
@paullouisageneau @golgirihm