-
-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add react and vue chainlink templates #154
feat: add react and vue chainlink templates #154
Conversation
Hey! Thanks a lot for your contribution. I'm in the middle of an overhaul for CEA v2, which will make this PR obsolete. But v2 will make it much, much easier for contributors like you to build templates for CEA. Do you feel this is urgent, and I should merge it in, or would you be happy to wait a little bit? ETA is currently mid of Sep. |
Hi @PaulRBerg. I leave that decision to you. I'm planning to add the chainlink templates for create-eth-app v2. If the v1 will be discontinued, maybe it doesn't make sense to merge this code. |
Great. That will be much easier to do, and maintain! |
Hi @PaulRBerg. Any updates about the v2? |
Hey @fabioDMFerreira, I got side-tracked with other projects and life-goals in the meantime .. Happy to re-open this if you'd be so kind to rebase from the latest commit on |
7de26c4
to
41101bb
Compare
@PaulRBerg I've rebased and fixed the linting issues. Please review. |
@fabioDMFerreira looks like you didn't give me permission to contribute to your fork.
I have made some other changes in the meantime and we have to rebase again - sorry! |
The templates read chainlink price feeds.