Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add react and vue chainlink templates #154

Merged

Conversation

fabioDMFerreira
Copy link
Contributor

The templates read chainlink price feeds.

@PaulRBerg
Copy link
Collaborator

Hey! Thanks a lot for your contribution.

I'm in the middle of an overhaul for CEA v2, which will make this PR obsolete. But v2 will make it much, much easier for contributors like you to build templates for CEA.

Do you feel this is urgent, and I should merge it in, or would you be happy to wait a little bit? ETA is currently mid of Sep.

@PaulRBerg PaulRBerg added the feature New feature or request label Aug 16, 2021
@fabioDMFerreira
Copy link
Contributor Author

Hi @PaulRBerg. I leave that decision to you.

I'm planning to add the chainlink templates for create-eth-app v2. If the v1 will be discontinued, maybe it doesn't make sense to merge this code.

@PaulRBerg
Copy link
Collaborator

I'm planning to add the chainlink templates for create-eth-app v2.

Great. That will be much easier to do, and maintain!

@PaulRBerg PaulRBerg closed this Aug 19, 2021
@fabioDMFerreira
Copy link
Contributor Author

Hi @PaulRBerg. Any updates about the v2?

@PaulRBerg
Copy link
Collaborator

Hey @fabioDMFerreira, I got side-tracked with other projects and life-goals in the meantime ..

Happy to re-open this if you'd be so kind to rebase from the latest commit on main and apply any changes that may be necessary.

@PaulRBerg PaulRBerg reopened this Feb 2, 2022
@fabioDMFerreira
Copy link
Contributor Author

@PaulRBerg I've rebased and fixed the linting issues. Please review.

@PaulRBerg PaulRBerg changed the base branch from develop to staging March 14, 2022 16:47
@PaulRBerg
Copy link
Collaborator

PaulRBerg commented Mar 15, 2022

@fabioDMFerreira looks like you didn't give me permission to contribute to your fork.

ERROR: Permission to appliedblockchain/create-eth-app.git denied to paulrberg.
fatal: Could not read from remote repository.

I have made some other changes in the meantime and we have to rebase again - sorry!

@PaulRBerg PaulRBerg merged commit 8c23fad into WalletConnect:staging Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants