Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pandoc --smart quotes and the HTML5 q element in DZslides #83

Closed
reagle opened this issue Mar 28, 2012 · 4 comments
Closed

pandoc --smart quotes and the HTML5 q element in DZslides #83

reagle opened this issue Mar 28, 2012 · 4 comments

Comments

@reagle
Copy link

reagle commented Mar 28, 2012

I just upgraded to the latest git version of pandoc and note one bit of stylistic breakage. pandoc --smart now renders HTML quotations as elements. Pandoc's dzslides default template.html render as a inline-block element, which leads to some visual breakage.

@hsablonniere
Copy link
Collaborator

I never used pandoc sorry. I just know that out display:block on the quotation phrasing elements is in the "Your style" section. Therefore it shouldn't impact any third party project that uses DZSlides since the core part doesn't have influence on those elements.

I'm not sure I'm seeing where you think DZSlides can handle this issue. Don't hesitate to detail your expectations from us.

Nevertheless you're still leading us to a small incorrect usage of q elements.

If I read correctly we should use a blockquote and the display:block would become useless.

http://html5doctor.com/blockquote-q-cite/
http://www.smashingmagazine.com/2008/06/12/block-quotes-and-pull-quotes-examples-and-good-practices/
http://www.amityadav.name/blockquote-vs-q-vs-cite/

@paulrouget What do you think ?

@reagle
Copy link
Author

reagle commented Mar 28, 2012

On 03/28/2012 03:03 PM, Hubert SABLONNIÈRE wrote:

I never used pandoc sorry. I just know that out display:block
on the quotation phrasing elements is in the "Your style" section.

Even so, I imagine people will use that section as a default starting
point and then modify it from there. If they do so, they will then bump
into the unusual styling for <q>.

I'm not sure I'm seeing where you think DZSlides can handle this
issue. Don't hesitate to detail your expectations from us.

Please don't define q as a block element.

If I read correctly we should use a blockquote and the
display:block would become useless.

Yes.

In the meantime, pandoc is removing that declaration for the time being.

On 03/28/2012 01:33 PM, John MacFarlane wrote:

I fixed this by removing the css for q in the dzslides template,
and replacing it with the same default we have in the html5 template..

@hsablonniere
Copy link
Collaborator

I just modified the code. If everyone agrees on this blockquote vs q issue, we'll merge.

Thx again @reagle ;-)

@paulrouget
Copy link
Owner

works for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants