Add a way to query for plugin directory #19
Comments
|
maybe |
enaess
added a commit
to enaess/ppp
that referenced
this issue
Mar 23, 2021
This adds pppd.pc into $(INSTROOT)/$(LIBDIR)/pkgconfig. On some distributions this would be /lib/pkgconfig, or /usr/lib/pkgconfig, but other distributions may consider specifying --libdir=/usr/lib/x86_x64-linux-gnu/ and the pkgconfig directory would be under that. Manually cherry picking parts of two commits by @lkundrak from: https://github.com/NetworkManager/ppp/tree/lr/pkgconfig Mainly, the difference between the original commit is not to replace DESTDIR with "prefix". Leave DESTDIR alone, and add needed pkgconfig (pppd.pc.in) as a part of the linux distribution (previously in pppd/plugin directory). Signed-off-by: Eivind Naess <eivnaes@yahoo.com>
enaess
added a commit
to enaess/ppp
that referenced
this issue
Mar 23, 2021
This adds pppd.pc into $(INSTROOT)/$(LIBDIR)/pkgconfig. On some distributions this would be /lib/pkgconfig, or /usr/lib/pkgconfig, but other distributions may consider specifying --libdir=/usr/lib/x86_x64-linux-gnu/ and the pkgconfig directory would be under that. Manually cherry picking parts of two commits by @lkundrak from: https://github.com/NetworkManager/ppp/tree/lr/pkgconfig Mainly, the difference between the original commit is not to replace DESTDIR with "prefix". Leave DESTDIR alone, and add needed pkgconfig (pppd.pc.in) as a part of the linux distribution (previously in pppd/plugin directory). Signed-off-by: Eivind Naess <eivnaes@yahoo.com>
enaess
added a commit
to enaess/ppp
that referenced
this issue
Apr 15, 2021
This adds pppd.pc into $(INSTROOT)/$(LIBDIR)/pkgconfig. On some distributions this would be /lib/pkgconfig, or /usr/lib/pkgconfig, but other distributions may consider specifying --libdir=/usr/lib/x86_x64-linux-gnu/ and the pkgconfig directory would be under that. Allowing --libdir to be specified at configure time fixes ppp-project#223, providing pkgconfig support fixes ppp-project#19 and allows third party packages pickup the plugin directory. Manually cherry picking parts of two commits by @lkundrak from: https://github.com/NetworkManager/ppp/tree/lr/pkgconfig Mainly, the difference between the original commit is not to replace DESTDIR with "prefix". Leave DESTDIR alone, and add needed pkgconfig (pppd.pc.in) as a part of the linux distribution (previously in pppd/plugin directory). This fixes GitHub issues: ppp-project#19 ppp-project#47 and ppp-project#223 Signed-off-by: Eivind Naess <eivnaes@yahoo.com>
|
PR: #270 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As discussed at:
https://bugs.gentoo.org/show_bug.cgi?id=519986
NetworkManager needs to get ppp plugin dir configured at build time with --with-pppd-plugin-dir=$(ppp_version). I have checked various distributions (debian, opensuse, fedora, arch...) and every one has a different workaround for this (some specify only a version, other checks for plugin dir running "ls" to know the one existing at that time (!)...)
Maybe would be interesting to provide a way to check for plugin dir used by built ppp that could allow other software to rely on it for building in proper place
Thanks a lot
The text was updated successfully, but these errors were encountered: