Skip to content
This repository has been archived by the owner on Dec 22, 2021. It is now read-only.

Mismatch between Cocoapods and Repo code? #4

Closed
aravasio opened this issue May 28, 2018 · 2 comments
Closed

Mismatch between Cocoapods and Repo code? #4

aravasio opened this issue May 28, 2018 · 2 comments

Comments

@aravasio
Copy link

aravasio commented May 28, 2018

I'm seeing huge differences between the code available in Cocoapods and the repo here in GH. Maybe Swift3 code??

Could there be an update pending? I'm interested in using this lib to skip doing some manual transformations, but as it is it won't build out of the box.

An example is

class TransformedCoordinateSpace : NSObject, UICoordinateSpace {
...
}

This class declaration is already different than what the repo in GH has, where declaration is ClassName: NSObject and the second extension is handled in an extension tag right below.

https://github.com/paulz/ImageCoordinateSpace/blob/master/ImageCoordinateSpace/TransformedCoordinateSpace.swift

@paulz
Copy link
Owner

paulz commented May 28, 2018

Cocoapods releases are made by tags, see latest example:
https://github.com/CocoaPods/Specs/blob/master/Specs/4/2/4/ImageCoordinateSpace/1.0.5/ImageCoordinateSpace.podspec.json#L15

While the link to GitHub in this issue points to master. Here is the correct link using the tag: https://github.com/paulz/ImageCoordinateSpace/blob/1.0.5/ImageCoordinateSpace/TransformedCoordinateSpace.swift

@paulz
Copy link
Owner

paulz commented May 29, 2018

Also, I've just released latest version 1.0.6 that supports Swift 4.1 and Xcode 9.3, see https://github.com/CocoaPods/Specs/blob/master/Specs/4/2/4/ImageCoordinateSpace/1.0.6/ImageCoordinateSpace.podspec.json#L16

Closing

@paulz paulz closed this as completed May 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants