Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ToDecimal with Into and From? #8

Closed
JP-Ellis opened this issue Jun 8, 2017 · 1 comment
Closed

Replace ToDecimal with Into and From? #8

JP-Ellis opened this issue Jun 8, 2017 · 1 comment

Comments

@JP-Ellis
Copy link
Contributor

JP-Ellis commented Jun 8, 2017

I was having a quick look through your code, and I see you have a new trait called ToDecimal which simply converts integer types into a decimal. I was curious as to why you didn't opt for the Into and From traits from the standard library which do exactly that?

Would you like a pull request to remove the ToDecimal trait and replace it with the standard library equivalent?

@JP-Ellis JP-Ellis changed the title Replace ToDecimal with Into? Replace ToDecimal with Into and From? Jun 8, 2017
@paupino
Copy link
Owner

paupino commented Jun 8, 2017

Short answer; there is no good reason for using ToDecimal and it should be updated to use Into and From. If you'd like to help contribute then I'd certainly be most grateful! Nevertheless, thank you for raising the issue - it's been a todo item for a while now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants