You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I was having a quick look through your code, and I see you have a new trait called ToDecimal which simply converts integer types into a decimal. I was curious as to why you didn't opt for the Into and From traits from the standard library which do exactly that?
Would you like a pull request to remove the ToDecimal trait and replace it with the standard library equivalent?
The text was updated successfully, but these errors were encountered:
JP-Ellis
changed the title
Replace ToDecimal with Into?
Replace ToDecimal with Into and From?
Jun 8, 2017
Short answer; there is no good reason for using ToDecimal and it should be updated to use Into and From. If you'd like to help contribute then I'd certainly be most grateful! Nevertheless, thank you for raising the issue - it's been a todo item for a while now.
I was having a quick look through your code, and I see you have a new trait called
ToDecimal
which simply converts integer types into a decimal. I was curious as to why you didn't opt for theInto
andFrom
traits from the standard library which do exactly that?Would you like a pull request to remove the
ToDecimal
trait and replace it with the standard library equivalent?The text was updated successfully, but these errors were encountered: