-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Event "onSwipeToClose" is not working #37
Comments
Hi, I guess your code is running on the emulator. This library is already running in my project, I feel good, thanks author. If you have any questions, I'd be happy to answer. :) |
Hi @alantoa Thanks for your reply but unfortunately it is not working on a real iOS device I have just tested it now. And another issue is Here's mine:
|
Hi, other than I see you example code, In addition to |
You can't use This library does not support scaling, This is only a image gallery, if you use Now I'm implementing the image lightbox effect use |
@usamaabutt did you figure a fix for using this lib under react-native-modal for onSwipeToClose ? |
I'm having the same issue and I'm not even using Modal |
I was about to reply that I was having the same issue but I went ahead and downgraded all of my dependencies to the same as the example: https://github.com/Flair-Dev/react-native-awesome-gallery/blob/main/example/package.json And it works. The culprit for me was Downgrading a major version may or may not be acceptable for your use cases. It would be great if this library could be updated for the new API. |
Can confirm this is an issue when using |
👋 Hi, everyone, It's been a few days and many people still have this problem, I will simply answer it. @mtflud Vertical doesn't working on emulator, The main problem that @gerryfletch @nateguy @FadiAboMsalam This library is awesome, I also learned a lot from this library. In fact, Thank you all! 🤝 |
@alantoa is there anything we can do to help you on that rewrite? we don't really understand or know what are the incompatibilities but we can allocate some hours trying to fix it as well, thanks! |
@felippepuhle Hi! |
@alantoa @felippepuhle |
Fixed in v0.3.0 by migration to RNGH v2 |
I am using the library for the image zoom feature and am thankful to the authors that they build it. But I am not able to get work "onSwipeToClose" event but all other events are working for me. I am using it as below. Any help will be appreciated thanks! @pavelbabenko @alantoa
<CustomModal isModalVisible={openZoomViewer} backdropOpacity={1}> <Gallery data={image} hideAdjacentImagesOnScaledImage={true} disableSwipeUp={true} renderItem={renderItem} onSwipeToClose={closeZoomViewer} onDoubleTap={closeZoomViewer} onIndexChange={(newIndex) => { console.log(newIndex); }} style={{ alignSelf: 'center' }} /> </CustomModal>
The text was updated successfully, but these errors were encountered: