Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong order of applying properties (in case of using cmake from *.props) #61

Closed
yrHeTaTeJlb opened this issue Dec 3, 2018 · 3 comments

Comments

@yrHeTaTeJlb
Copy link
Contributor

yrHeTaTeJlb commented Dec 3, 2018

Sometimes it is necessary to rewrite values set by converter

@yrHeTaTeJlb yrHeTaTeJlb changed the title Set appropriate default values for "Ouput Directory" Put props files at the end of CMakeLists.txt Dec 4, 2018
@yrHeTaTeJlb yrHeTaTeJlb reopened this Dec 4, 2018
@bigla
Copy link

bigla commented Dec 4, 2018

Not intending to pollute the issue tracker, but how about starting a collection of variable mappings?

  • Translating props variables to cmake:
    <WindowsTargetPlatformVersion> == ${CMAKE_VS_WINDOWS_TARGET_PLATFORM_VERSION}

  • Translating vcxproject variables to cmake:

$(Configuration) == ${CMAKE_CFG_INTDIR} # info: https://cmake.org/cmake/help/v3.0/variable/CMAKE_CFG_INTDIR.html
$(Platform) == ${CMAKE_VS_PLATFORM_NAME}

@pavelliavonau
Copy link
Owner

@bigla, if you have proposals like this, create another issue for separate discussion, please.

@pavelliavonau
Copy link
Owner

Moving props is not enough.
Order for properties must be following:

  1. Apply default values.
  2. Apply values from props.
  3. Apply values from project.

@pavelliavonau pavelliavonau reopened this Dec 14, 2018
@pavelliavonau pavelliavonau changed the title Put props files at the end of CMakeLists.txt Wrong order of applying properties (in case of using cmake from *.props) Dec 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants