Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support (number of photos, customize buttons) #31

Closed
anirudhamahale opened this issue Apr 7, 2017 · 2 comments
Closed

Support (number of photos, customize buttons) #31

anirudhamahale opened this issue Apr 7, 2017 · 2 comments

Comments

@anirudhamahale
Copy link

I am using your library and it's very good, thanks for source code.
I would like to request you to add things like

  1. Maximum number of photos or media that we can select
  2. Customize the default button i.e Snap Image or Video and send x items
  3. Update the documentation on how to call the delegate methods on the PPOption buttons
    let option = PPOption(withTitle: "Pick Image") { // I want to call assetsPicker(_ picker: PPAssetsActionController, didFinishPicking assets: [MediaProvider]) method on click of this button }

This is what I found should be added.

@pavelpantus
Copy link
Owner

pavelpantus commented Apr 7, 2017

Hey, @anirudhamahale , thank you for your feedback! Greatly appreciated!
I'll file separate issues for each of you request to track them separately when I have a chance.

To clarify on point 3: do you want PPAssetsActionController to call you back when one of the options was selected? If so, I'd go with a new PPAssetsActionControllerDelegate method, something like:

func assetsPicker(_ picker: PPAssetsActionController, didPickOption option: PPOption);

Let me know what you think, thanks!

@pavelpantus
Copy link
Owner

Closing in favor of #32 #33 #34
I encourage you to take a stab at any of it without waiting my implementation.
Just communicate in the ticket that you're interested in implementing a feature, so I'd know and we avoid implementing the same feature twice.
Thanks again for filing the ticket @anirudhamahale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants