Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paver-minilib.zip changing by each sdist #45

Closed
ponty opened this issue Jan 26, 2012 · 5 comments
Closed

Paver-minilib.zip changing by each sdist #45

ponty opened this issue Jan 26, 2012 · 5 comments
Assignees
Milestone

Comments

@ponty
Copy link

ponty commented Jan 26, 2012

Paver-minilib.zip file content is changing by each sdist task call, because the file modification time is always updated
in the PKZip header. There was no such behavior in previous versions.
I use git and I don't know if file change is important or just time update.

Version: Paver 1.0.5

@ponty
Copy link
Author

ponty commented Feb 5, 2012

I resolved this problem by downgrading paver to 1.0.3

@yedpodtrzitko
Copy link

tried to replicate this problem, but without any success. Can you provide some more details?

@ponty
Copy link
Author

ponty commented Apr 3, 2012

You are right, I use paved where the sdist task is overidden with minilib dependency.

@task
@needs('get_distribute', 'generate_setup', 'minilib', 'manifest', 'setuptools.command.sdist')
def sdist():
    """Overrides sdist to make sure that our setup.py is generated.
    """
    pass

To replicate this problem run paver minilib

@Almad
Copy link
Member

Almad commented Apr 3, 2012

@ponty The fact that minilib regenerates minilib is intentional. I am hesistant to change it...would it be OK if it would be configurable via options?

Can you please elaborate on how paver version is affecting that?

@ponty
Copy link
Author

ponty commented Apr 13, 2012

My experience was that running Paver 1.0.5 overwrites existing minilib.zip, but Paver 1.0.3 doesn't.
I think that it would be better first to check existing minilib.zip content,
and only overwrite if it is not OK.

@ghost ghost assigned yedpodtrzitko Jul 29, 2012
@ponty ponty closed this as completed Aug 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants