Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make env fails without requirements-dev.txt #97

Closed
adeadman opened this issue Jul 20, 2018 · 1 comment
Closed

make env fails without requirements-dev.txt #97

adeadman opened this issue Jul 20, 2018 · 1 comment

Comments

@adeadman
Copy link

Description

When setting up a test development environment, the included Makefile has a target env that should create a virtual environment and install the development dependencies. However, the make env command fails because requirements-dev.txt is not present in the repository.

Steps to Reproduce

  1. git clone the repository
  2. Change to the repository directory
  3. run make env

Expected behavior: The environment is installed and ready for development and testing

Actual behavior: The virtualenv is created, but pip fails to install dependencies with error Could not open requirements file: [Errno 2] No such file or directory: 'requirements-dev.txt'

Reproduces how often: all the time

Versions

Not applicable

Additional Information

This is on branch master, but it may be present in other branches.

@pavlov99
Copy link
Owner

@adeadman thank you for the issue report.

Historically Makefile was used as a set of shortcuts, make test or make env are some of them.

As this project aims to support multiple python environments, it uses tox as the main environment manager and this is preferred way compared to make env. To avoid confusions, I've removed make env and make test commands. tox -e <ENV> should be used instead.

Hope this resolves the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants