Custom configs

[jonnieey]

Simple custom binds and color configuration from file.

[pawamoy]

Yay! Thank you very much for your contribution, I'll take the time to review properly the next days.

I see however that you pushed already merged commits? What happened? Could you try to rebase your branch on master to resolve the merge conflicts?

[jonnieey]

Ok. I'm new to github, sorry for any inconviniences :-).

[pawamoy]

No problem, I'll do my best to help you!

In your branch, the commands should be

git rebase master
# fix any conflict, follow what git is telling you
# now you can "force push" to your branch
git push -f

Please don't hesitate to ask if something is unclear :)

[pawamoy]

Oh, I think I can also push to your branch. I'll try to do it later if you didn't do it first ^^

[pawamoy]

Don't worry too much about CI (quality and tests jobs), they were already failing before.

[pawamoy]

Hey @jonnieey, I didn't forget about your PR, I simply was very busy these last weeks (moving out / moving in, work) and I want to review your PR properly, which require a decent amount of time 🙂 But I'll get to it eventually! Sorry it's taking so long for your first contribution 😄

[pawamoy]

Thanks again @jonnieey, these are great additions 🙂

I would have preferred a more modern configuration format like YAML/TOML, but I think the INI format is OK to start with.

One other thing that bothers me is that we can only have one key for an action now? We could previously use both q and F1 to display help, and now it's only F1?

[pawamoy]

Hello @jonnieey, I commited some changes:

• create the configuration file if it does not exist, write the default configuration values
• remove config.ini
• add the vim-keybindings in the default config

How do you feel about this PR? I would like to merge it and continue integrating it properly (like adding tests, fixing CI, etc.)

[jonnieey]

Hey @pawamoy. I think it's a good start for custom user configurations. There's room for a lot of improvement that can be made along the way.

[pawamoy]

@jonnieey alright great! I'll squash and merge. Feel free to send more PRs 😉

[pawamoy]

Oops, your authoring was dropped from the commits, let me fix this.

[pawamoy]

@jonnieey I can't find back your git author name and email, can you give them to me 🙂 ?

I insist.

[pawamoy]

Nevermind, found it!

[pawamoy]

Sorry for this mess 😅 It's fixed!