Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate transform_default #56

Open
ziima opened this issue Aug 23, 2019 · 6 comments
Open

Deprecate transform_default #56

ziima opened this issue Aug 23, 2019 · 6 comments

Comments

@ziima
Copy link
Collaborator

ziima commented Aug 23, 2019

I don't really see the point in the transform_default argument. It seems quite straightforward to provide the default value the same way it should be set up in settings. I'm in favor of deprecating the transform_default and eventually removing it and transform the default in all cases.

@ziima
Copy link
Collaborator Author

ziima commented Mar 30, 2020

Any comments on this? Otherwise, I'd start with first steps to deprecate it.

@pawamoy
Copy link
Owner

pawamoy commented Mar 30, 2020

It was useful when providing a callable as default, and actually calling it to get the default value at runtime, though if nobody's using I'm OK to deprecate it.

@ziima
Copy link
Collaborator Author

ziima commented Mar 30, 2020

The idea is to transform the default always, unless the call_default is True. I intent to keep the possibility of a callable default.

@pawamoy
Copy link
Owner

pawamoy commented Mar 30, 2020

Ah yes, I forgot that. Then it was useful when you wanted to transform the value returned by the callable as well haha. But then the callable could indeed directly return the final value, so it's not that useful.

@stinovlas
Copy link
Collaborator

I'm okay with that, but it should be noted that transform_default is currently False by default and you are proposing to change it to True, which means it's a breaking change and it should be noted in the changelog and preferably even in release notes.

@ziima
Copy link
Collaborator Author

ziima commented Apr 6, 2020

Seems I will need to solve #37 first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants