New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make some ring fields, in particular the file descriptor, available externally #13

Open

prr123 opened this issue Nov 18, 2023 · 0 comments

prr123 commented Nov 18, 2023 •

edited

Loading

type Ring has fd fields that are not available externally (lower case), but the file descripter in particular is required as parameter in the method (*ring).Register (https://github.com/pawelgaczynski/giouring/blob/69588b89acb9/syscall.go#L94).

Currently, the alternative is not to use the library method QueueInit and instead implement Setup (https://github.com/pawelgaczynski/giouring/blob/69588b89acb9/syscall.go#L72) which return the file descriptor.

ps. I discovered that you added a method in setup.go (*ring)RingFd().
Would it not be cleaner to define the fields externally?

baryluk mentioned this issue

All Params fields are private #15

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment