Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weather widget relies on hardcoded host:port #18

Closed
rgriffogoes opened this issue Jun 10, 2021 · 0 comments · Fixed by #21
Closed

Weather widget relies on hardcoded host:port #18

rgriffogoes opened this issue Jun 10, 2021 · 0 comments · Fixed by #21
Assignees
@pawelmalak
Labels
🐞 Bug Something isn't working
Milestone
v1.2 Release

Comments

@rgriffogoes
Copy link
Contributor

This client code has a hardcoded localhost:5005

client/src/components/Widgets/WeatherWidget/WeatherWidget.tsx

This fails if the app is accessed outside the server, and if the exposed port is changed (e.g: docker deployments):

WeatherWidget.tsx:53 WebSocket connection to 'ws://localhost:5005/' failed:
@pawelmalak pawelmalak self-assigned this Jun 10, 2021
@pawelmalak pawelmalak added the 🐞 Bug Something isn't working label Jun 10, 2021
@pawelmalak pawelmalak added this to the Version 1.2 milestone Jun 10, 2021
@pawelmalak pawelmalak linked a pull request Jun 10, 2021 that will close this issue
Release v1.2 #21
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pawelmalak pawelmalak

Labels
🐞 Bug Something isn't working
Projects
None yet
Milestone
v1.2 Release
Development

Successfully merging a pull request may close this issue.

Release v1.2 pawelmalak/flame
2 participants
@rgriffogoes @pawelmalak