Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to categories to "Applications" #7

Closed
Nelinski opened this issue Jun 8, 2021 · 6 comments · Fixed by #21
Closed

Ability to categories to "Applications" #7

Nelinski opened this issue Jun 8, 2021 · 6 comments · Fixed by #21
Assignees
Labels
🔨 Feature New feature or request
Milestone

Comments

@Nelinski
Copy link

Nelinski commented Jun 8, 2021

The ability to add different categories for "Applications" similar to how you can do with "Bookmarks".

The ability to add icons for "Bookmarks" would be nice too.

@pawelmalak pawelmalak added this to Ideas in Flame Project Board Jun 8, 2021
@pawelmalak
Copy link
Owner

Hi. The ability to categorize applications most likely won't be implemented since it's against my idea of how this "App Hub" should work. I wanted to keep it clean and simple as it is in the SUI.

As for the icons. Are you talking about adding them to categories or to single bookmakrs/links?

@pawelmalak
Copy link
Owner

Implementation proposal:

Opera Zrzut ekranu_2021-06-09_124209_localhost

@pawelmalak pawelmalak added the 🔨 Feature New feature or request label Jun 9, 2021
@pawelmalak pawelmalak self-assigned this Jun 9, 2021
@pawelmalak pawelmalak added this to the Version 1.2 milestone Jun 9, 2021
@Nelinski
Copy link
Author

Nelinski commented Jun 9, 2021

I was thinking single icons as per your proposal. My thought process behind the "Application" categories was to bring it more inline with the "Bookmarks" to keep a cleaner UI if you've got a lot of "Applications". Either way, nice work 👍🏻

@pawelmalak pawelmalak linked a pull request Jun 10, 2021 that will close this issue
@fdarveau
Copy link

@Nelinski If you want categories for applications, I have forked this repository and added that feature, along with some extras, such as being able to sort bookmarks like apps. It is available here : https://github.com/fdarveau/flame.
There might still be some issues I have not found since there were some major changes involved, as @pawelmalak mentioned.

I have also set up automatic docker images via GitHub Actions. You can use the container ghcr.io/fdarveau/flame:latest

@pawelmalak : If you are interested, I could open a PR. It might have way too many changes though since I have auto-formatting turned on and it seems to have some issues with react apps or my settings.

In any case, I have also setup a GitHub Action to try to keep my fork updated regularly (once a week). If the merge fails, I get notified so I can merge manually.

@Nelinski
Copy link
Author

@fdarveau Works great, thanks!

@NoLooseEnds
Copy link

@fdarveau I'm having an issue getting it to work properly.

I just changed out the image with yours ghcr.io/fdarveau/flame:latest, and added - flame.category=My category to the docker labels.

I'm currently testing on a docker-compose with three containers. I'm trying with - flame.category=Downloads, but still get the Docker default category. I did try with a completely new Flame config too.

Excerpt from my docker-compose.yml:

      - flame.type=application # "app" works too
      - flame.name=Radarr
      - flame.url=https://radarr.${TRAEFIK_BASE_DNS}
      - flame.category=download
      - flame.icon=file-download-outline  # Optional, default is "docker"
      - flame.order=1 # Optional, default is 500; lower number is first in the list      

But still get the default category:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 Feature New feature or request
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants