Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Icons do not persist when adding apps via docker labels #91

Closed
BackedUpBooty opened this issue Sep 26, 2021 · 3 comments · Fixed by #93
Closed

Custom Icons do not persist when adding apps via docker labels #91

BackedUpBooty opened this issue Sep 26, 2021 · 3 comments · Fixed by #93

Comments

@BackedUpBooty
Copy link

I have a number of containers which I've set up with the label variables as follows:

      - flame.type=application
      - flame.name=exampleApp
      - flame.url=192.168......:port

Once inside the flame GUI, I went through and manually changed all the icons to custom icons (generally the relevant service's logo) and it all looked great. But when refreshing the page, all the custom icons disappeared and were replaced by the default docker icon.

Have I missed something about using the label variables? I know you can set the mdi from them too, is there a way I should be setting the custom icons?

If it makes any difference, the same apps which use labels also get unpinned.

@pawelmalak
Copy link
Owner

@pruizlezcano

@pruizlezcano
Copy link
Contributor

pruizlezcano commented Sep 26, 2021

There isn't a option for custom icons. If you don't provide an icon name it puts the default docker icon. I will take a look this week.

What option would you rather to use, define flame.icon=custom in the docker-compose or not saying nothing about the icon (same as the issue example)?

@BackedUpBooty
Copy link
Author

Sorry I should have been clearer, I meant when using the custom icon upload in the GUI where you can choose a file;
image

But otherwise yeah a defined flame-icon=custom would be great! But then you may want to also have to define the icon inside /app/data, so something like flame.custom.icon.path=/app/data/path/to/icon.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants