ignored constant sym param

[Dayvison]

Code:

#if defined a
	#error "a"
#else
	#error "b"
#endif
main() { }

Command used:
pawncc.exe m.pwn a=1

Zeex compiler:

Pawn compiler 3.10.2                    Copyright (c) 1997-2006, ITB CompuPhase

m.pwn(4) : fatal error 111: user error: "b"


Compilation aborted.


1 Error.

Original compiler:

m.pwn(2) : fatal error 111: user error: "a"


Compilation aborted.

Pawn compiler 3.2.3664                  Copyright (c) 1997-2017, ITB CompuPhase


1 Error.

[YashasSamaga]

What's happening?

1. The compiler parses the compiler options at the very beginning.
2. The compiler deletes the constants given as compiler options before it parses.

So any constants which were added when the compiler options were parsed are deleted.

While it does not delete the predefined constants (constants with flagPREDEF), it deletes the rest (which includes constants passed to the compiler as arguments).

https://github.com/Zeex/pawn/blob/00f21e67d543bf6eeda5943a8891caeeb0a991d2/SOURCE/compiler/sc1.c#L1155

add_constant(str,i,sGLOBAL,0); should be add_builtin_constant(str,i,sGLOBAL,0); for constants given through compiler arguments?

[Southclaws]

+1 I use this and I only found about this bug today, it would really screw up my build process if I migrated to this compiler (which I wanted to for SS).

@YashasSamaga could you submit a pull request with the proposed fix?