Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove emit keyword. #448

Closed
Y-Less opened this issue Sep 23, 2019 · 1 comment
Closed

Remove emit keyword. #448

Y-Less opened this issue Sep 23, 2019 · 1 comment

Comments

@Y-Less
Copy link
Member

Y-Less commented Sep 23, 2019

Issue description:

When asm was originally proposed there was some discussion here:

#180 (comment)

And the name __emit was instead agreed on as the best name - both for consistency with #emit and to reduce the chances of clashing with existing code by using the compiler-reserved prefix __. However, emit was also added as a keyword despite being a valid user-symbol.

Minimal complete verifiable example (MCVE):

main()
{
    new a = emit(ZERO.pri);
}

Workspace Information:

  • Compiler version:
  • Command line arguments provided (or sampctl version):
  • Operating System:
@Y-Less
Copy link
Member Author

Y-Less commented Sep 23, 2019

If a script wants this, it should be optionally enabled, not on by default:

#define emit __emit

@AmyrAhmady AmyrAhmady mentioned this issue Oct 1, 2019
4 tasks
@Y-Less Y-Less closed this as completed Oct 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant