Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

paws.storage::get_object curl timingout #371

Closed
DyfanJones opened this issue Jan 25, 2021 · 4 comments
Closed

paws.storage::get_object curl timingout #371

DyfanJones opened this issue Jan 25, 2021 · 4 comments

Comments

@DyfanJones
Copy link
Member

HI all,

Has there been a major change between paws.database 0.1.9 and 0.1.10? Currently a user from the noctua package is getting a timeout issue (DyfanJones/noctua#132).

Any advice would be greatly appreciated :)

@DyfanJones DyfanJones changed the title paws.database curl timingout paws.storage::get_object curl timingout Jan 25, 2021
@DyfanJones
Copy link
Member Author

To help this issue I have done a breakdown of the noctua wrapper method of dbGetQuery to help identify the possible issue. DyfanJones/noctua#132 (comment)

From this I believe the best culprit would be paws.storage::s3()$get_objects when it makes it's curl call to s3 and ultimately gets a timeout error

Error in curl::curl_fetch_memory(url, handle = handle): Timeout was reached: [REDACTED.s3.us-east-2.amazonaws.com] Operation timed out after 10000 milliseconds with 119006796 out of 316782524 bytes received

@DyfanJones
Copy link
Member Author

I believe the issue stems from this commit: c65e813 . Where new_http_request gets a timeout of 10 seconds.

@davidkretch
Copy link
Member

davidkretch commented Jan 25, 2021

Hey, sorry about that! We've updated paws.common on CRAN to have no default timeout again. With the fix we are able to download large files that take >10 seconds.

@DyfanJones
Copy link
Member Author

@davidkretch thanks for the fast fix. I will close this now 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants