Support taproot PSBTs #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Right now our receiver only adds default getnewaddress which is typically bech32. This may fail for senders checking against mixed script inputs. |
|
|
Sometimes taproot signers leave around taproot signing artifacts. Part of the spec is to remove unnecessary psbt data for counterparties, so this ensures removal of taproot variety unnecessary data too.
|
@jbesraa please review this manipulation as it relates to BIP 78. Mutiny and bitmask will try to add taproot inputs for receivers and this makes that possible. We'll need to follow that with some dynamic address type selection in payjoin-cli that this makes possible. |
|
I'm inclined to roll a release this change as a patch since it doesn't change the API and some taproot payjoin spends to taproot receivers are broken until the fix is applied. |
jbesraa
approved these changes
Dec 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes taproot signers leave around taproot signing artifacts.
Part of the spec is to remove unnecessary psbt data for counterparties,
so this ensures removal of taproot variety unnecessary data too.
Before this change it was possible for bitcoind's walletprocesspsbt to fail when it didn't have to because superfluous psbt data was present on the original psbt. This falls in line with the sender checklist, see "The Original PSBT MUST"