Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjusts activation constraint of draggable nodes #2773

Merged
merged 1 commit into from
Jun 5, 2023

Conversation

jacobsfletch
Copy link
Member

@jacobsfletch jacobsfletch commented Jun 5, 2023

Description

Fixes a bug where pills with select fields not being easily clearable. This was especially evident on relationships with multi-value. The problem was with the events provided by dnd-kit, which were overriding click events if you're mouse was moving when the event took place. Fortunately that package supplies an API to constrain the activation of the drag event.

  • I have read and understand the CONTRIBUTING.md document in this repository

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Existing test suite passes locally with my changes

@jacobsfletch jacobsfletch merged commit 863be3d into master Jun 5, 2023
4 checks passed
@jacobsfletch jacobsfletch deleted the fix/select-clear branch June 5, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant