Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: #2711 index sortable field global versions fields #2775

Merged
merged 1 commit into from
Jun 6, 2023
Merged

fix: #2711 index sortable field global versions fields #2775

merged 1 commit into from
Jun 6, 2023

Conversation

DanRibbens
Copy link
Contributor

@DanRibbens DanRibbens commented Jun 5, 2023 •
edited

Description

fixes #2711

Before changes:

image

After changes:

image

  • I have read and understand the CONTRIBUTING.md document in this repository

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have added tests that prove my fix is effective or that my feature works
  • Existing test suite passes locally with my changes
  • I have made corresponding changes to the documentation

@DanRibbens
Copy link
Contributor Author

@JarrodMFlesch I thought you'd be a good person for reviewing this one. Thank you!

@DanRibbens DanRibbens merged commit 576af01 into master Jun 6, 2023
4 checks passed
@DanRibbens DanRibbens deleted the fix/#2711-indexSortableFields-globals branch June 6, 2023 18:46
AlessioGr added a commit that referenced this pull request Jun 6, 2023
@AlessioGr @DanRibbens
@jacobsfletch @jmikrut @denolfe
Update feat/rtl-support branch (#2787)
ac12f62 
* fix: #2711 index sortable field global versions fields (#2775)

* fix: read-only Auth fields (#2781)

* fix: read-only Auth fields (#2781)

* chore: uses discord vanity urls (#2786)

* chore: updated yarn lock

* fix: improperly typing optional arrays with required fields as required

* test: entityToJSONSchema test for optional arrays with required fields

---------

Co-authored-by: Dan Ribbens <DanRibbens@users.noreply.github.com>
Co-authored-by: Dan Ribbens <dan.ribbens@gmail.com>
Co-authored-by: Jacob Fletcher <jacobsfletch@gmail.com>
Co-authored-by: James <james@trbl.design>
Co-authored-by: Elliot DeNolf <denolfe@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JarrodMFlesch JarrodMFlesch Awaiting requested review from JarrodMFlesch

Assignees

@JarrodMFlesch JarrodMFlesch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Activate versions, drafts for globals in azure cosmos
2 participants
@DanRibbens @JarrodMFlesch