Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: number field validation #4233

Merged
merged 1 commit into from
Nov 21, 2023
Merged

fix: number field validation #4233

merged 1 commit into from
Nov 21, 2023

Conversation

JarrodMFlesch
Copy link
Contributor

Description

Fixes issue where validating numbers such as 0 (a falsey number) would result in an incorrect validation. See comment here: #4052 (comment)

  • I have read and understand the CONTRIBUTING.md document in this repository.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have added tests that prove my fix is effective or that my feature works
  • Existing test suite passes locally with my changes
  • I have made corresponding changes to the documentation

@JarrodMFlesch JarrodMFlesch mentioned this pull request Nov 21, 2023
Merged
4 tasks
@JarrodMFlesch JarrodMFlesch merged commit 19fcfc2 into main Nov 21, 2023
29 checks passed
@JarrodMFlesch JarrodMFlesch deleted the fix/number-field-validation branch November 21, 2023 15:12
@mvdve mvdve mentioned this pull request Dec 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denolfe denolfe Awaiting requested review from denolfe

@jmikrut jmikrut Awaiting requested review from jmikrut

@DanRibbens DanRibbens Awaiting requested review from DanRibbens

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@JarrodMFlesch