-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(richtext-lexical)!: lazy import React components to prevent client-only code from leaking into the server #4290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to prevent lag and flashes when parent component re-renders
… well by hoisting it up to the workspace root and making it configurable
… default from Features
TODO:
|
…nly exports to /components subpath export
…ported from the / subpath export anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4085
Breaking Change:
@payloadcms/richtext-lexical
to v0.4.0 or higher, you will HAVE to updatepayload
to the latest version as well. If you don't update it, payload likely won't start up due to validation errors. It's generally good practice to upgrade packages prefixed with@payloadcms/
together withpayload
and keep the versions in sync.@payloadcms/richtext-slate
is not affected by this.Feature
interface which accepts a React component now no longer accepts a React component, but a function which imports a React component instead. This is done to ensure no unnecessary client-only code is leaked to the server when importing Features on a server.Here's an example migration:
Old:
New:
Or alternatively, if you're using default exports instead of named exports:
The types for
SanitizedEditorConfig
andEditorConfig
have changed. Their respectivelexical
property no longer expects theLexicalEditorConfig
. It now expects a function returning theLexicalEditorConfig
. You will have to adjust this if you adjusted that property anywhere, e.g. when initializing the lexical field editor property, or when initializing a new headless editor.The following exports are now exported from the
@payloadcms/richtext-lexical/components
subpath exports instead of@payloadcms/richtext-lexical
:ToolbarButton
ToolbarDropdown
RichTextCell
RichTextField
defaultEditorLexicalConfig
You will have to adjust your imports, only if you import any of those properties in your project.
Type of change
Checklist: