Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(richtext-lexical)!: improve floating select menu Dropdown classNames #4444

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

AlessioGr
Copy link
Member

@AlessioGr AlessioGr commented Dec 11, 2023

Description

  • Added extra unique class name for Dropdown button
  • Fix incorrect aria label
  • Fix incorrect className for Dropdown caret

Breaking:

  • Dropdown component has a new mandatory sectionKey prop

  • I have read and understand the CONTRIBUTING.md document in this repository.

Type of change

  • Chore (non-breaking change which does not add functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Change to the templates directory (does not affect core functionality)
  • Change to the examples directory (does not affect core functionality)
  • This change requires a documentation update

Checklist:

  • I have added tests that prove my fix is effective or that my feature works
  • Existing test suite passes locally with my changes
  • I have made corresponding changes to the documentation

@AlessioGr AlessioGr added the plugin: richtext-lexical @payloadcms/richtext-lexical label Dec 11, 2023
@AlessioGr AlessioGr changed the title feat(richtext-lexical): improve floating select menu Dropdown classNames feat(richtext-lexical)!: improve floating select menu Dropdown classNames Dec 11, 2023
@AlessioGr AlessioGr merged commit 9331204 into main Dec 11, 2023
29 checks passed
@AlessioGr AlessioGr deleted the feat/lexical-dropdown-class-names branch December 11, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: richtext-lexical @payloadcms/richtext-lexical
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant