Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: detect language from request headers accept-language #4656

Merged
merged 1 commit into from
Jan 2, 2024
Merged

fix: detect language from request headers accept-language #4656

merged 1 commit into from
Jan 2, 2024

Conversation

JarrodMFlesch
Copy link
Contributor

@JarrodMFlesch JarrodMFlesch commented Jan 2, 2024 •
edited

Description

Allows reading the language from request headers.

  • I have read and understand the CONTRIBUTING.md document in this repository.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have added tests that prove my fix is effective or that my feature works
  • Existing test suite passes locally with my changes
  • I have made corresponding changes to the documentation

@JarrodMFlesch JarrodMFlesch changed the title allows reading language from header like the docs say fix: allows reading language from header like the docs say Jan 2, 2024
@JarrodMFlesch JarrodMFlesch changed the title fix: allows reading language from header like the docs say fix: detect language from request headers accept-language Jan 2, 2024
@JarrodMFlesch JarrodMFlesch merged commit 69a9944 into main Jan 2, 2024
29 checks passed
@JarrodMFlesch JarrodMFlesch deleted the fix/i18n-from-header branch January 2, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmikrut jmikrut Awaiting requested review from jmikrut

@jacobsfletch jacobsfletch Awaiting requested review from jacobsfletch

@denolfe denolfe Awaiting requested review from denolfe

@DanRibbens DanRibbens Awaiting requested review from DanRibbens

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@JarrodMFlesch