Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the navigation locking out if the modal is closed using the esc… #4664

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

paulpopus
Copy link
Contributor

Closes #4116

Description

The modals would lock navigation out if they were quit using the escape key

  • I have read and understand the CONTRIBUTING.md document in this repository.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have added tests that prove my fix is effective or that my feature works
  • Existing test suite passes locally with my changes
  • I have made corresponding changes to the documentation

@DanRibbens DanRibbens merged commit be3beab into main Jan 3, 2024
29 checks passed
@DanRibbens DanRibbens deleted the fix/4116-fixes-modal-locking-nav-out-on-esc branch January 3, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Buttons/Links stop working when closing "unsaved changes" prompt with Escape key
2 participants