fix: disable api key checkbox does not remove api key #6017
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5742
The checkbox to disable API Keys did not clear the
apiKey
from form state. The request on save after unchecking still had it.This change makes it so that apiKey is sent to the API as
null
so that it can be properly saved without a key.The e2e test associated with the feature was passing because it didn't properly send the apiKey to test against in the /me route 馃う.
I've also changed the API Key index hook so that local operations passing data respect the request moving forward. The following scenarios will result in a usable API Key:
data: { apiKey: '0987654321', enableAPIKey: true }
Updates made with the following will prevent the API key auth strategy for the user:
data: { enableAPIKey: false }
data: { enableAPIKey: null }
data: { apiKey: false }
data: { apiKey: null }
End result:
Type of change
Checklist: