Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: user verification email broken #6442

Merged
merged 1 commit into from
May 21, 2024
Merged

Conversation

JessChowdhury
Copy link
Member

@JessChowdhury JessChowdhury commented May 21, 2024

Description

Closes #225.

The user verification emails are not being sent and this error is shown:

APIError: Error sending email: 422 validation_error - Invalid `from` field. The email address needs to follow the `email@example.com` or `Name <email@example.com>` format.

The issue is resolved by updating the from property on the outgoing verification email:

from: `"${email.defaultFromName}" <${email.defaultFromName}>`,
// to
from: `"${email.defaultFromName}" <${email. defaultFromAddress}>`,

NOTE: This was not broken in 2.0, see correct outgoing email here.

  • I have read and understand the CONTRIBUTING.md document in this repository.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Existing test suite passes locally with my changes

@JessChowdhury JessChowdhury enabled auto-merge (squash) May 21, 2024 13:13
@JessChowdhury JessChowdhury merged commit 23f9a32 into beta May 21, 2024
36 checks passed
@JessChowdhury JessChowdhury deleted the fix/beta/verify-email-bug branch May 21, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG + FIX - Verification email uses defaultFromName instead of defaultFromEmail
2 participants