Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improves generated types by removing unnecessary optional prope… #784

Merged
merged 1 commit into from Jul 20, 2022

Conversation

jmikrut
Copy link
Member

@jmikrut jmikrut commented Jul 20, 2022

…rties

Description

Some field types (groups, blocks, arrays) were unnecessarily being set to optional, because our APIs automatically populate empty objects / arrays, so this change improves our overall generated types.

  • I have read and understand the CONTRIBUTING.md document in this repository

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have added tests that prove my fix is effective or that my feature works
  • Existing test suite passes locally with my changes

@jmikrut jmikrut merged commit 6f748f1 into master Jul 20, 2022
@jmikrut jmikrut deleted the feat/improve-generated-types branch July 20, 2022 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant