made refactoring and added test for browser_instance fixture #7
Conversation
|
Changes Unknown when pulling b06a0e9 on issue5 into * on master*. |
| @@ -176,16 +176,22 @@ def browser_instance( | |||
| }, **splinter_firefox_profile_preferences) | |||
| if splinter_driver_kwargs: | |||
| kwargs.update(splinter_driver_kwargs) | |||
There was a problem hiding this comment.
let's rename the fixture to reflect what it returns
also i think we should make it session scoped, as patching happens there and we return a function, so it's safe and efficient to make it session scoped
There was a problem hiding this comment.
Okay, I agree. But which name? get_browser_instance? browser_get_instance?
There was a problem hiding this comment.
browser_instance_getter
On 28 June 2014 23:11, Andrey Makhnach notifications@github.com wrote:
In pytest_splinter/plugin.py:
@@ -176,16 +176,22 @@ def browser_instance(
}, **splinter_firefox_profile_preferences)
if splinter_driver_kwargs:
kwargs.update(splinter_driver_kwargs)Okay, I agree. But which name? get_browser_instance? browser_get_instance?
—
Reply to this email directly or view it on GitHub
https://github.com/paylogic/pytest-splinter/pull/7/files#r14326262.
Anatoly Bubenkov
|
Changes Unknown when pulling 838b9a7 on issue5 into * on master*. |
|
Changes Unknown when pulling 7528079 on issue5 into * on master*. |
| @@ -176,16 +176,22 @@ def browser_instance( | |||
| }, **splinter_firefox_profile_preferences) | |||
bubenkoff
force-pushed
the
issue5
branch
5 times, most recently
from
41233a3
to
8577081
Compare
made refactoring and added test for browser_instance fixture
Made changes related to #5