Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verkeerde check op state in functie Transaction->isRefunded #23

Closed
rreuvekamp opened this issue Apr 29, 2016 · 1 comment
Closed

Verkeerde check op state in functie Transaction->isRefunded #23

rreuvekamp opened this issue Apr 29, 2016 · 1 comment

Comments

@rreuvekamp
Copy link

In src/Result/Transaction/Transaction.php vanaf regel 79 staat het volgende:

    if ($this->data['paymentDetails']['state'] == 'REFUND') {
        return true;
    }

    if ($allowPartialRefunds && $this->data['paymentDetails']['stateName'] == 'PARTIAL_REFUND') {
        return true;
    }

Moet de eerste check niet checken op de stateName in plaats van de state? Volgens de API docs (en de rest van de code in het bestand) is state de status-code/integer, en stateName inderdaad de string.

@andypieters
Copy link
Contributor

Klopt helemaal, ik pas het aan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants