New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

semver issue for breaking change #47

Closed

bakkerpeter opened this issue Mar 20, 2018 · 2 comments

bakkerpeter commented Mar 20, 2018

I think you should change the version for the latest to 2.x.x.

Contributor

andypieters commented Mar 20, 2018

Why? there is no breaking change.
Yes the SDK now supports login with a tokencode, but if you omit it, it should still work.

Author

bakkerpeter commented Mar 20, 2018

Ok that's great, the release message might be a bit misleading. Thanks for the quick response.

bakkerpeter closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment