Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename: PayPalNativeCheckout prefix for Native checkout integration #97

Merged
merged 3 commits into from Oct 18, 2022

Conversation

jcnoriega
Copy link
Contributor

Thank you for your contribution to PayPal.

Before submitting this PR, note that we cannot accept language translation PRs. We have a dedicated localization team to provide the translations. If there is an error in a specific translation, you may open an issue and we will escalate it to the localization team.

Summary of changes

  • Refactor to rename all of the classes to start with the prefix PayPalNativeCheckout

Checklist

  • Added a changelog entry

Authors

List GitHub usernames for everyone who contributed to this pull request.

@jcnoriega jcnoriega self-assigned this Oct 17, 2022
@jcnoriega jcnoriega requested a review from a team as a code owner October 17, 2022 16:19
@codecov
Copy link

codecov bot commented Oct 17, 2022

Codecov Report

Merging #97 (aac60fc) into main (5e09c1c) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main      #97   +/-   ##
=========================================
  Coverage     39.82%   39.82%           
  Complexity       76       76           
=========================================
  Files            57       57           
  Lines           673      673           
  Branches         69       69           
=========================================
  Hits            268      268           
  Misses          385      385           
  Partials         20       20           
Flag Coverage Δ
card 14.13% <ø> (ø)
core 58.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e09c1c...aac60fc. Read the comment docs.

Copy link
Collaborator

@sshropshire sshropshire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌊

@sshropshire
Copy link
Collaborator

q: Does this need to happen on iOS too?

@jcnoriega
Copy link
Contributor Author

@sshropshire this is to align Android to iOS actually

@sshropshire
Copy link
Collaborator

@jcnoriega ah 👍

@jcnoriega jcnoriega merged commit 98b5c41 into main Oct 18, 2022
@jcnoriega jcnoriega deleted the refactor_native branch October 18, 2022 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants