Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add before and after screenshot events to the element event listener. #249

Closed
wants to merge 1 commit into from

Conversation

renelux
Copy link
Contributor

@renelux renelux commented Feb 22, 2016

We need this method to make changes to the webpage before a screenshot gets taken. SeLion by default takes screenshots of the whole page (which we love). But a lot of websites nowadays are using floating headers/elements, this means that when the page is scrolled the header shows in the middle of the page.

This becomes a problem for the QA's that review the screenshots, with this change we can add a scroll up before the screenshot gets take, and scroll down afterwards.

@mach6
Copy link
Contributor

mach6 commented Feb 23, 2016

@renelux will take a look at this soon. sorry I missed you on gitter

@renelux
Copy link
Contributor Author

renelux commented Feb 23, 2016

@mach6 no worries not in a rush. Issues is already identified just need to find a good way to fix it. This way would work (already tried it locally) you just need to approve it. No pressure ;)

@mach6
Copy link
Contributor

mach6 commented Apr 7, 2016

@renelux I'm okay with this change.I'll merge it in the morning.

@mach6
Copy link
Contributor

mach6 commented Apr 7, 2016

@renelux sorry, I just noticed. I need you to fix the author (~/.gitconfig user.email and user.name) of this commit so that it complies the project's contribution policy.

@mach6 mach6 added this to the 1.1.0 milestone Apr 7, 2016
@renelux
Copy link
Contributor Author

renelux commented Apr 12, 2016

@mach6 I updated my commit info

@mach6
Copy link
Contributor

mach6 commented Apr 12, 2016

thx @renelux .. you sure about the email address? this will be the 3rd address the history has for you. :)

@renelux
Copy link
Contributor Author

renelux commented Apr 12, 2016

@mach6 sometimes I work on my PayPal machine and sometimes on Symbio's that is why it is not always the same :) The paypalcorp.com are the new address I think, but @paypal.com still works so I can change it for you.

@renelux
Copy link
Contributor Author

renelux commented Apr 12, 2016

@mach6 I updated my email again.

@mach6
Copy link
Contributor

mach6 commented Apr 12, 2016

this is merged.

@mach6 mach6 closed this Apr 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants